Add OPEN_PANEL_CANCELLED and SAVE_PANEL_CANCELLED commands #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, I've been thinking about adding context methods for file dialogs similarly to those for windows, menus and future alerts. It's probably okish to add those as long as they go into no release. Did you leave of the changelog intentionally? I think it should be included temporarily, even if they are going to be removed again. |
|
oops changelog was an oversight, updated. |
cmyr
force-pushed
the
cancel-dialog-commands
branch
2 times, most recently
from
1b3981e
to
fc835a2
Compare
luleyleo
reviewed
Jun 26, 2020
cmyr
commented
Jun 26, 2020
cmyr
added
S-needs-review
cmyr
force-pushed
the
cancel-dialog-commands
branch
from
5945df8
to
373cb01
Compare
This lets the user take special action if needed in either of these cases.
cmyr
force-pushed
the
cancel-dialog-commands
branch
from
373cb01
to
5bc7dae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets the user take special action if needed in either of
these cases.
I needed this in order to implement a "you have unsaved changes" prompt in Runebender, while testing out #1039. I think that we may want to further modify the general alerts API, and I think that we should try and make the open and save panels use a similar API to whatever we come up with for alerts, more generally, in which case this might be a stop-gap solution.