Add Ref lens and use move semantics for lens! macro index. #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jneem
approved these changes
Sep 2, 2020
| @@ -125,6 +125,51 @@ pub trait LensExt<A: ?Sized, B: ?Sized>: Lens<A, B> { | |||
| self.then(Deref) | |||
| } | |||
|
|
|||
| /// Invoke a type's `AsRef` and `AsMut` impl. | |||
| /// | |||
| /// It also allows indexing arrays with the [`index`] lens as shown in the example. | |||
There was a problem hiding this comment.
maybe worth explaining that this is because Index is implemented for slices, and not arrays. Otherwise it's a little mysterious (to me, anyway) why reffing allowing indexing to work
There was a problem hiding this comment.
Good idea! I've added a note.
|
this will need a rebase to pass CI. |
This allows passing a variables and not just constants for indexing arrays.
luleyleo
force-pushed
the
add-ref-lens
branch
from
99b7865
to
ad41dfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1138.
See the linked issue for the reasoning behind this.