Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Button::from_label #1226

Merged
merged 1 commit into from
Sep 13, 2020

Conversation

ForLoveOfCats
Copy link
Collaborator

When using Button I wanted to be able to use the builder fns on Label. Rather than stub them all on Button and try to keep it up to date with Label as new fns are added it felt much simpler and cleaner to simply allow constructing a Button with a provided Label. There is no corresponding dynamic_from_label, one can use Label::dynamic to achieve that.

@ForLoveOfCats ForLoveOfCats added enhancement adds or requests a new feature widget concerns a particular widget S-needs-review waits for review labels Sep 12, 2020
@ForLoveOfCats ForLoveOfCats reopened this Sep 12, 2020
@ForLoveOfCats
Copy link
Collaborator Author

Something's going nuts with the nightly CI, it appears to be failing to install the toolchain

@raphlinus
Copy link
Contributor

Probably fallout from https://rust-lang.github.io/rustup-components-history/x86_64-apple-darwin.html ; our CI scripts are not robust against failures there.

Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions but nothing blocking, this looks like a good addition!

druid/src/widget/button.rs Outdated Show resolved Hide resolved
druid/src/widget/button.rs Outdated Show resolved Hide resolved
druid/src/widget/button.rs Outdated Show resolved Hide resolved
druid/src/widget/button.rs Show resolved Hide resolved
@ForLoveOfCats ForLoveOfCats merged commit d225c3e into linebender:master Sep 13, 2020
@maan2003 maan2003 removed the S-needs-review waits for review label May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement adds or requests a new feature widget concerns a particular widget
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants