Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make dialogs on windows non-sychronous. #1328

Merged
merged 3 commits into from
Oct 29, 2020
Merged

Make dialogs on windows non-sychronous. #1328

merged 3 commits into from
Oct 29, 2020

Conversation

jneem
Copy link
Collaborator

@jneem jneem commented Oct 17, 2020

This does #1068 for windows.

@jneem
Copy link
Collaborator Author

jneem commented Oct 19, 2020

@rhzk I got an email notification that you left a comment, but I can't see it now...

@cmyr cmyr added the S-needs-review waits for review label Oct 26, 2020
@jneem
Copy link
Collaborator Author

jneem commented Oct 28, 2020

Now that mac support has landed, I've updated this PR to remove the backwards-compatibility glue.

cmyr
cmyr approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Looks like there might be some clippy stuff to clean up now, but happy to have this all sorted out, thanks again for taking this on!

@jneem jneem merged commit 5a127c3 into linebender:master Oct 29, 2020
@maan2003 maan2003 removed the S-needs-review waits for review label May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmyr cmyr cmyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jneem @cmyr @maan2003