Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide get_external_handle on DelegateCtx #1526

Merged
merged 2 commits into from
Jan 11, 2021
Merged

Provide get_external_handle on DelegateCtx #1526

merged 2 commits into from
Jan 11, 2021

Conversation

maan2003
Copy link
Collaborator

No description provided.

cmyr
cmyr approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

druid/src/win_handler.rs
@@ -193,20 +193,22 @@ impl<T: Data> Inner<T> {
/// is configured.
fn with_delegate<R, F>(&mut self, f: F) -> Option<R>
where
F: FnOnce(&mut Box<dyn AppDelegate<T>>, &mut T, &Env, &mut DelegateCtx) -> R,
F: FnOnce(&mut dyn AppDelegate<T>, &mut T, &Env, &mut DelegateCtx) -> R,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@maan2003 maan2003 merged commit 5fbbeb4 into linebender:master Jan 11, 2021
@maan2003 maan2003 deleted the delegatectx-get-external-handle branch January 11, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmyr cmyr cmyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maan2003 @cmyr