Correctly capture and use stroke properties when rendering SVG paths #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maan2003
approved these changes
Mar 13, 2021
|
I think the best answer here is to not have A simple answer is |
derekdreery
pushed a commit
to derekdreery/druid
that referenced
this pull request
Apr 6, 2021
…inebender#1647) * Use correct LineJoin and LineCap behavior in svg widget * Correctly set miter limit and dash array properties when rendering SVG paths with stroke * Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the SVG widget to fetch and use properties about stroke style, such as line cap and dash array.
This has not been thoroughly tested since the new properties have a one-to-one mapping with
StrokeStylein piet. It has passed a smoke test in a project I'm working on, which has 12 unique SVG icons. Some of these icons also now render correctly where they didn't before.I'm a little iffy about is the
Vecclone. I don't think it's avoidable here, but I want to point it out since Druid goes to great lengths to avoid it elsewhere.