Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax constraints on who can change focus #1651

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Relax constraints on who can change focus #1651

merged 1 commit into from
Mar 16, 2021

Conversation

cmyr
Copy link
Member

@cmyr cmyr commented Mar 16, 2021

Instead of just the focus widget this is now available to any of
that widget's direct ancestors (such as a controller).

This is needed for the new TextBox, since the widget with
the logic (TextBox) is not the widget that necessarily
has focus (the SharedComponent).

This is broken out of #1636.

Instead of just the focus widget this is now available to any of
that widget's direct ancestors (such as a controller).

This is needed for the new TextBox, since the widget with
the logic (TextBox) is not the widget that necessarily
has focus (the SharedComponent).
Copy link
Collaborator

@maan2003 maan2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Sounds reasonable

@cmyr cmyr merged commit 9c36187 into master Mar 16, 2021
@cmyr cmyr deleted the focus-child branch March 16, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants