Fix alignment offset for selection in TextBox #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The alignment offset was accidentally added instead of subtracted from the cursor position.
|
It might be wrong in more places such as |
cmyr
approved these changes
May 10, 2021
There was a problem hiding this comment.
Cool, I was quite confused by this but it looks like I broke it somewhere during the IME work.
cursor_line_for_text_position is fine; it's supposed to be the inverse operation (figuring out where to visually draw the cursor, for a given text position, as opposed to figuring out the text position for a cursor position).
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The alignment offset was accidentally added instead of subtracted from the cursor position.
Fixes #1767