Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fluent #1772

Merged
merged 1 commit into from
May 11, 2021
Merged

Update fluent #1772

merged 1 commit into from
May 11, 2021

Conversation

r-ml
Copy link
Contributor

@r-ml r-ml commented May 11, 2021

No description provided.

r-ml
r-ml commented May 11, 2021
View reviewed changes
druid/src/localization.rs
@@ -154,7 +154,7 @@ impl ResourceManager {
debug!("resolved: {}", PrintLocales(resolved_locales.as_slice()));
let mut stack = Vec::new();
for locale in &resolved_locales {
let mut bundle = FluentBundle::new(&resolved_locales);
let mut bundle = FluentBundle::new(resolved_locales.clone());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/projectfluent/fluent-rs/blob/fluent-bundle%400.13.0/fluent-bundle/src/bundle.rs#L67-L84 vs. https://github.com/projectfluent/fluent-rs/blob/fluent-bundle%400.15.0/fluent-bundle/src/bundle.rs#L577-L589. This is the clone that was there before

@r-ml r-ml marked this pull request as ready for review May 11, 2021 01:22
maan2003
maan2003 approved these changes May 11, 2021
View reviewed changes
Copy link
Collaborator

@maan2003 maan2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@maan2003 maan2003 added the S-ready PR is ready to merge label May 11, 2021
@maan2003 maan2003 merged commit a2b9fe9 into linebender:master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maan2003 maan2003 maan2003 approved these changes

Assignees
No one assigned
Labels
S-ready PR is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@r-ml @maan2003