Improve unsafe code in GTK clipboard code #1820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uli Schlachter <psychon@znc.in>
When putting text data into the clipboard, the platform code was calling std::str::from_utf8_unchecked() on the data. That's not really valid, because the caller can provide arbitrary bytes. Thus, this commit replaces that with a call to std::str::from_utf8(). In case invalid utf8 was provided, the selection is instead set as raw bytes. I am not sure what will happen "down the road" with this, but it seems to be the best that can be done. Fixes: linebender#1814 Signed-off-by: Uli Schlachter <psychon@znc.in>
Signed-off-by: Uli Schlachter <psychon@znc.in>
jneem
reviewed
Jun 6, 2021
Signed-off-by: Uli Schlachter <psychon@znc.in>
psychon
force-pushed
the
gtk-clipboard-unsafe-str
branch
from
280bb68
to
76c6e7d
Compare
jneem
approved these changes
Jun 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also reported gtk-rs/gtk3-rs#564 to make
gdk::Atom::value()safe (or at least to figure out why it is unsafe).