x11: Set WM_CLASS on windows #1868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I compared "xprop" output between a random window with the gtk and x11 backends and noticed that WM_CLASS is missing, even though it is required by ICCCM. This commit implements setting the WM_CLASS property on x11. This was tested via "xprop": gtk and x11 backends now produce the same value for the WM_CLASS property. Signed-off-by: Uli Schlachter <psychon@znc.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I compared "xprop" output between a random window with the gtk and x11
backends and noticed that WM_CLASS is missing, even though it is
required by ICCCM.
This commit implements setting the WM_CLASS property on x11.
This was tested via "xprop": gtk and x11 backends now produce the same
value for the WM_CLASS property.
Signed-off-by: Uli Schlachter psychon@znc.in