Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

widget::Container requests paint when Key has changed #1881

Merged
merged 2 commits into from
Jul 27, 2021
Merged

widget::Container requests paint when Key has changed #1881

merged 2 commits into from
Jul 27, 2021

Conversation

maan2003
Copy link
Collaborator

Fixes #1880

cmyr
cmyr approved these changes Jul 26, 2021
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, good solution. Two nits in the comments you're free to ignore 🤷

druid/src/widget/painter.rs Outdated Show resolved Hide resolved
druid/src/widget/painter.rs Outdated Show resolved Hide resolved
@maan2003 @cmyr
Apply suggestions from code review
22dd029 
Co-authored-by: Colin Rofls <colin@cmyr.net>
@maan2003 maan2003 merged commit 8bd8805 into linebender:master Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmyr cmyr cmyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Container doesnot request_paint when env value is changed
2 participants
@maan2003 @cmyr