Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added strikethrough #1953

Merged
merged 7 commits into from
Sep 18, 2021
Merged

Added strikethrough #1953

merged 7 commits into from
Sep 18, 2021

Conversation

melody-notpond
Copy link
Contributor

This pull request adds strikethrough to druid and updates the markdown example to use ~~this syntax~~ for strikethrough.

Copy link
Collaborator

@maan2003 maan2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Probably a good idea to add this to example as well.

@melody-notpond
Copy link
Contributor Author

melody-notpond commented Sep 3, 2021

Thanks! Probably a good idea to add this to example as well.

@maan2003 Which example is that?

@maan2003
Copy link
Collaborator

maan2003 commented Sep 3, 2021

markdown_preview.rs, I meant in the sample text

@cmyr
Copy link
Member

cmyr commented Sep 3, 2021

Worth noting that I think this may only work on certain platforms, maybe even only linux? I don't recall exactly the state of this in piet.

@melody-notpond
Copy link
Contributor Author

Worth noting that I think this may only work on certain platforms, maybe even only linux? I don't recall exactly the state of this in piet.

Oh no. I have no way to test it on Windows/macOS and don't know how to test it on the web. I may send a pull request for piet if thats the case, since I really want strikethrough for my matrix client. Any idea how I can start tackling this?

@cmyr
Copy link
Member

cmyr commented Sep 3, 2021

Here's the tracking issue, without much info. It may be that this is now only missing on mac? in any case I'll post some more info here: linebender/piet#301

@jneem
Copy link
Collaborator

jneem commented Sep 16, 2021

This can be merged, right?

@jneem
Copy link
Collaborator

jneem commented Sep 18, 2021

I'm going to take that as a "yes"

@jneem jneem merged commit f2e78ab into linebender:master Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants