Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to readme.md #1992

Merged
merged 4 commits into from
Oct 1, 2021
Merged

Conversation

winksaville
Copy link
Contributor

For me hello_web, web and sub_window didn't work see readme.md.

For me hello_web, web and sub_window didn't work see readme.md.
@JAicewizard
Copy link
Contributor

JAicewizard commented Sep 28, 2021

Thanks for the contribution! This was a very dragged out pull request, seems like some things slipped through.

EDIT:
I mean the original PR adding this readmewas long, not this one.

On my desktop computer with dual monitors one vertical and one horzitional
the "Drag me" window was not always visible on either of my monitors.
By removing the call to `set_poistion` the "Drag me" window appears in
the middle of the "main window" and is always initially visible.
Copy link
Contributor Author

@winksaville winksaville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should we do with hello_web and web?

druid/examples/readme.md Show resolved Hide resolved
druid/examples/readme.md Outdated Show resolved Hide resolved
druid/examples/readme.md Outdated Show resolved Hide resolved
druid/examples/readme.md Outdated Show resolved Hide resolved
I have no idea why they didn't work for me before, but the are working
now. So I'll leave well enough alone :)
@winksaville
Copy link
Contributor Author

What should we do with hello_web and web?

I retested and they are working now. I've removed the "Not working ..." sentences in readme.md and thing this PR is ready to merge.

Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cmyr
Copy link
Member

cmyr commented Sep 29, 2021

@JAicewizard if you're happy with this I'm happy to merge :)

@cmyr cmyr merged commit 8f4693d into linebender:master Oct 1, 2021
@winksaville winksaville deleted the Fixes-to-examples/readme.md branch October 1, 2021 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants