Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing import in gtk/window.rs #2011

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Fix missing import in gtk/window.rs #2011

merged 1 commit into from
Nov 10, 2021

Conversation

klemensn
Copy link
Contributor

Cherry-picked from jpochyla/druid@a9522f5 .

Otherwise building jpochyla/psst on Linux or OpenBSD fails:

error[E0433]: failed to resolve: use of undeclared type `XcbHandle`
   --> /home/kn/src/druid/druid-shell/src/backend/gtk/window.rs:118:30
    |
118 |         RawWindowHandle::Xcb(XcbHandle::empty())
    |                              ^^^^^^^^^ not found in this scope
    |

This code was introduced in 2da53f0 which
seems to target Windows and Mac but not Linux, so I assume that is why it
went unnoticed.

@jpochyla @klemensn
Fix missing import in gtk/window.rs
ef806c3 
Cherry-picked from jpochyla/druid@a9522f5 .

Otherwise building jpochyla/psst on Linux or OpenBSD fails:
```
error[E0433]: failed to resolve: use of undeclared type `XcbHandle`
   --> /home/kn/src/druid/druid-shell/src/backend/gtk/window.rs:118:30
    |
118 |         RawWindowHandle::Xcb(XcbHandle::empty())
    |                              ^^^^^^^^^ not found in this scope
    |
```

This code was introduced in 2da53f0 which
seems to target Windows and Mac but not Linux, so I assume that is why it
went unnoticed.
@klemensn
Copy link
Contributor Author

This is required to build druid on at least OpenBSD as jpochyla/psst dependency without any further patches (modulo feature changes in jpochyla/druid).

See jpochyla/psst#191 (comment) .

maan2003
maan2003 approved these changes Nov 10, 2021
View reviewed changes
Copy link
Collaborator

@maan2003 maan2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think CI doesnot test with raw-win-handle feature

@maan2003 maan2003 merged commit 909f1f3 into linebender:master Nov 10, 2021
@klemensn klemensn deleted the gtk-import branch November 12, 2021 15:58
@klemensn
Copy link
Contributor Author

Pardon the noise, I meant put this comment #1993 (comment) here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maan2003 maan2003 maan2003 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@klemensn @maan2003 @jpochyla