Make Widget trait event fn conform to argument order of other fn's. #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmyr
approved these changes
Nov 17, 2019
|
#308 will need to be updated. |
Merged
ratmice
added a commit
that referenced
this pull request
Dec 28, 2019
cmyr
pushed a commit
that referenced
this pull request
Dec 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #154
I'm not sure when a good time to merge this would be, the things noted in the issue seem to have been merged (multiwin), but if necessary feel free to ping me at that time and I can deal with any fallout that happens between now and then.