Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use GTK optional feature #611

Merged
merged 1 commit into from
Apr 12, 2020
Merged

Remove use GTK optional feature #611

merged 1 commit into from
Apr 12, 2020

Conversation

pyroxymat
Copy link
Contributor

@pyroxymat pyroxymat commented Mar 7, 2020 •
edited
Loading

Closes #604

@cmyr
Copy link
Member

cmyr commented Mar 8, 2020

Thanks! I'd like to hold this off until we get #599 merged, to try and keep that as uncomplicated as possible, but we can revisit then. :)

@cmyr cmyr added the S-blocked waits for another PR or dependency label Mar 22, 2020
@cmyr cmyr added S-waiting-on-author waits for changes from the submitter and removed S-blocked waits for another PR or dependency labels Apr 6, 2020
@cmyr
Copy link
Member

cmyr commented Apr 6, 2020

@pyroxymat with #599 merged, we can look at this again?

@ratmice
Copy link
Collaborator

ratmice commented Apr 6, 2020

@cmyr would the cfg_aliases crate released yesterday reduce the maintenance burden around this?

@cmyr
Copy link
Member

cmyr commented Apr 7, 2020

That does look useful! Ideally things will simplify a bit with us dropping GTK as a feature, but we can definitely keep that in mind if it still feels hairy.

@totsteps
Copy link
Collaborator

totsteps commented Apr 10, 2020 •
edited
Loading

@pyroxymat can we have the merge conflicts resolved? No rush though.
Thanks.

@pyroxymat pyroxymat force-pushed the remove-use-gtk branch 2 times, most recently from 558a85c to ddb5e98 Compare April 12, 2020 14:08
@pyroxymat
Copy link
Contributor Author

Fixed the PR

@cmyr cmyr added S-needs-review waits for review and removed S-waiting-on-author waits for changes from the submitter labels Apr 12, 2020
luleyleo
luleyleo approved these changes Apr 12, 2020
View reviewed changes
Copy link
Collaborator

@luleyleo luleyleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good and works on Linux.

cmyr
cmyr approved these changes Apr 12, 2020
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cmyr cmyr merged commit ff73f67 into linebender:master Apr 12, 2020
@xStrom xStrom removed the S-needs-review waits for review label May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmyr cmyr cmyr approved these changes

@luleyleo luleyleo luleyleo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove use-gtk feature
6 participants
@pyroxymat @cmyr @ratmice @totsteps @luleyleo @xStrom