Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace #[macro_use] with normal use #808

Merged
merged 4 commits into from
Apr 8, 2020
Merged

Replace #[macro_use] with normal use #808

merged 4 commits into from
Apr 8, 2020

Conversation

totsteps
Copy link
Collaborator

@totsteps totsteps commented Apr 7, 2020 •
edited
Loading

closes #805

@totsteps totsteps requested a review from luleyleo April 7, 2020 01:47
@totsteps totsteps added the S-needs-review waits for review label Apr 7, 2020
luleyleo
luleyleo approved these changes Apr 7, 2020
View reviewed changes
Copy link
Collaborator

@luleyleo luleyleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good, thanks 👍
@cmyr I think we can get this merged

cmyr
cmyr requested changes Apr 7, 2020
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny nit, but otherwise looks good, thanks!

druid-shell/src/platform/windows/dialog.rs Outdated Show resolved Hide resolved
xStrom
xStrom approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

cmyr
cmyr approved these changes Apr 8, 2020
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, this sort of little cleanup is always appreciated.

druid-shell/src/keyboard.rs
use std::fmt;

use super::keycodes::KeyCode;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 😄

@cmyr cmyr merged commit d4cb921 into linebender:master Apr 8, 2020
@totsteps totsteps deleted the replace_macro_use branch April 8, 2020 07:10
@xStrom xStrom removed the S-needs-review waits for review label May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xStrom xStrom xStrom approved these changes

@cmyr cmyr cmyr approved these changes

@luleyleo luleyleo luleyleo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace #[macro_use] with normal use
4 participants
@totsteps @xStrom @cmyr @luleyleo