Handle keyboard and button state in X11 events. #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xStrom
reviewed
May 11, 2020
There was a problem hiding this comment.
Generally looks good.
The helper methods mouse_button / mouse_buttons / key_mods don't really need to be methods though, they don't use self. Let's make them associated functions for example by removing the &self paramater and then calling them as Window::mouse_buttons(....). Alternatively can just move them into the module scope, e.g. to the bottom of the file.
xStrom
added
S-waiting-on-author
|
Thanks for the review! I've moved the functions in question to the module scope. |
|
Yeah that looks better. Need a rebase with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #893.