Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impl Shape for QuadBez, CubicBez, & PathSeg #150

Merged
merged 2 commits into from Oct 20, 2020
Merged

Impl Shape for QuadBez, CubicBez, & PathSeg #150

merged 2 commits into from Oct 20, 2020

Conversation

cmyr
Copy link
Member

@cmyr cmyr commented Oct 20, 2020

No description provided.

raphlinus
raphlinus approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@raphlinus raphlinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, a few concerns inline.

src/bezpath.rs Outdated Show resolved Hide resolved
src/quadbez.rs Outdated Show resolved Hide resolved
@cmyr cmyr merged commit 73faa21 into master Oct 20, 2020
@cmyr cmyr deleted the more-shapes branch October 20, 2020 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphlinus raphlinus raphlinus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cmyr @raphlinus