Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include a default layer with a _notdef glyph by default #17

Closed
wants to merge 1 commit into from

Conversation

cmyr
Copy link
Member

@cmyr cmyr commented Nov 27, 2019

This changse the behaviour of Ufo::default() to always create
the default layer, and populate it with the '.notdef' glyph.

I'm not 100% sure that this makes sense; it's motivated by wanting
to have a glyph defined when starting a new project in runebender.

@madig
Copy link
Collaborator

madig commented Nov 27, 2019

I wouldn't do this. In TruFont, you can set the glyph set for new fonts in the preferences. It's something that you set a default for in the application (e.g. A-Za-z0-9.,/space) but not hardcode into norad.

This changse the behaviour of Ufo::default() to always create
the default layer, and populate it with the '.notdef' glyph.

I'm not 100% sure that this makes sense; it's motivated by wanting
to have a glyph defined when starting a new project in runebender.
@cmyr cmyr force-pushed the include-default-layer-by-default branch from 4c86b62 to ad492c8 Compare November 27, 2019 21:21
@cmyr
Copy link
Member Author

cmyr commented Nov 27, 2019

okay, good info. I'll find a more private way to do this.

@cmyr cmyr closed this Nov 27, 2019
@cmyr cmyr deleted the include-default-layer-by-default branch November 27, 2019 22:17
@madig
Copy link
Collaborator

madig commented Nov 28, 2019

Revisiting this, I would however create a default layer in Ufo::default(). The population of it should be done elsewhere. The goal here would be to have an empty UFO that one can save immediately and have it be valid.

@cmyr
Copy link
Member Author

cmyr commented Nov 28, 2019

yea, I noticed that issue when working on this and on #18, and I agree.

@madig
Copy link
Collaborator

madig commented Dec 4, 2019

I think all you need is a metainfo.plist, a layercontents.plist and a glyphs/ dir with at least contents.plist, i.e. an empty layer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants