Align the style of the README with Vello #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfrg
reviewed
Jan 25, 2024
README.md
Outdated
| @@ -9,9 +24,32 @@ This library is in early development stages and will initially contain the relev | |||
| from [piet-scene] but the intent is to be a generally useful set of primitives for vector | |||
There was a problem hiding this comment.
piet-scene appears to be a dead link now. I imagine the historical significance of this is no longer relevant and this entire line should probably be removed though it will leave the readme rather bare.
|
LGTM, modulo the line about piet-scene. |
|
I'd say capitalize "peniko" to "Peniko" and we're good to merge. |
PoignardAzur
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RENDERED
See linebender/vello#233, which implemented this for Vello
Working towards #17