Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TextLayout::update_width #306

Merged
merged 1 commit into from Sep 16, 2020
Merged

Remove TextLayout::update_width #306

merged 1 commit into from Sep 16, 2020

Conversation

cmyr
Copy link
Member

@cmyr cmyr commented Sep 12, 2020

See #298

closes #298

raphlinus
raphlinus approved these changes Sep 12, 2020
View reviewed changes
Copy link
Contributor

@raphlinus raphlinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like we should pour one out for this feature. But I believe it will return, when we're ready.

@cmyr cmyr merged commit 05e51a7 into master Sep 16, 2020
@cmyr cmyr deleted the remove-update-width branch September 16, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphlinus raphlinus raphlinus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TextLayout::update_width buggy by design
2 participants
@cmyr @raphlinus