Fix inconsistent transformations (#62), cleanup #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elias Naur <mail@eliasnaur.com>
eliasnaur
changed the title
Signed-off-by: Elias Naur <mail@eliasnaur.com>
The NVIDIA shader compiler bug that forced splitting of the state struct into primitive types is now fixed. Signed-off-by: Elias Naur <mail@eliasnaur.com>
We're about to run two aggregates, one for transforms and another for the rest of the element state. Signed-off-by: Elias Naur <mail@eliasnaur.com>
The non-deterministic evaluation order of the state monoid may end up assigning inconsistent transformations to path endpoints. This change avoids that problem by evaluating transformation state before all other state. Fixes linebender#62 Signed-off-by: Elias Naur <mail@eliasnaur.com>
eliasnaur
force-pushed
the
transform-monoid
branch
from
196adc7
to
9b2a39a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work branch:
As usual, my commits are self-contained and you may review and accept or reject from in any order; I'll handle the rebase and reordering before submitting.