-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xilem_web
: Panic using BoxedView
inside HTML element
#274
Comments
Hmm this is a tricky one, I think it's this issue: https://stackoverflow.com/questions/73807369/cant-downcast-from-mut-boxdyn-trait-as-mut-dyn-any I.e. in the |
github-merge-queue bot
pushed a commit
that referenced
this issue
Jun 28, 2024
This ports xilem_web to the new xilem_core. There's also a lot of cleanup internally: * Get rid of all of the complex macros to support DOM interfaces, and instead use associated type bounds on the `View::Element`. * Introduce an extendable modifier based system, which should also work on top of memoization (`Arc`, `Memoize`) and `OneOf` views with an intersection of the modifiable properties. * This modifier based system gets rid of the hacky way to propagate attributes to elements, and takes inspiration by masonrys `WidgetMut` type to apply changes. * Currently that means `Attributes`, `Classes` and `Styles` to reflect what xilem_web previously offered. Downsides (currently, needs some investigation): ~~Due to more internal type complexity via associated types this suffers from rust-lang/rust#105900. The new trait solver should hopefully mitigate some of that, but it seems currently it completely stalls in the todomvc example (not in other examples).~~ ~~The deep, possibly completely static composition via associated type-bounds of the view and element tree unfortunately can take some time to compile, this gets (already) obvious in the todomvc example. The other examples don't seem to suffer that bad yet from that issue, probably because they're quite simple.~~ ~~I really hope we can mitigate this mostly, because I think this is the idiomatic (and more correct) way to implement what the previous API has offered.~~ One idea is to add a `Box<dyn AnyViewSequence>`, as every element takes a "type-erased" `ViewSequence` as parameter, so this may solve most of the issues (at the slight cost of dynamic dispatch/allocations). Edit: idea was mostly successful, see comment right below. I think it also closes #274 It's a draft, as there's a lot of changes in xilem_core that should be upstreamed (and cleaned up) via separate PRs and I would like to (mostly) fix the slow-compile time issue. --------- Co-authored-by: Daniel McNab <36049421+DJMcNab@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When trying to use a
BoxedView
in anhtml::div
I get the following panic:Reproducible by changing the counter example:
Stack trace
This looks to be related to
Pod::downcast_mut
, where the underlying element type is incorrect.I'm also not using any conditionals or a
ViewSequence
so this is definitely confusing to me, maybeAnyView
is storing the wrong type?The text was updated successfully, but these errors were encountered: