Work in progress xilem prototype #1

raphlinus · 2022-11-16T21:56:23Z

This is a snapshot of the current state of the xilem prototype built on new infrastructure: glazier for window creation, piet-gpu for drawing, and parley for text.

As of this snapshot, only the text widget has been ported, and there are a number of rough edges. It should be considered a proof of concept. That said, it should be possible to build more from here.

This is a snapshot of the current state of the xilem prototype built on new infrastructure: glazier for window creation, piet-gpu for drawing, and parley for text. As of this snapshot, only the text widget has been ported, and there are a number of rough edges. It should be considered a proof of concept. That said, it should be possible to build more from here.

I've chosen not to deny warnings in CI because we currently have warnings. Once #1 lands, we can enforce cleanliness of warnings

We don't deny warnings in CI because we currently have warnings. Once #1 lands, we can enforce cleanliness from warnings See also linebender/glazier@d0b9e19 as we only use windows at the moment

ghost · 2022-11-17T12:47:50Z

Text is blurry.

Is high DPI detection enabled/implemented?

dzhou121 · 2022-11-17T12:53:30Z

I guess this question is more for piet-gpu, but how are we going to manage the text rendering on different platforms? Like you'll probably need sub-pixel rendering for Windows, but not necessary for Macs.

ghost · 2022-11-17T12:55:52Z

@dzhou121 don't know if that's useful, but we had a small convo about text rendering here

dzhou121 · 2022-11-17T13:01:10Z

https://xi.zulipchat.com/#narrow/stream/296640-font-tech/topic/Pathfinder.20approach.20vs.2E.20defer.20to.20native

Thanks. I can see it's a discussion of the mechanisms of text rendering. My question is more user level, i.e. does text look the same or different across different OS, or Xilem will expose some API for you to choose.

ghost · 2022-11-17T13:03:51Z

Hm. I suppose we can always expose a config to, say, enable font dilation on Windows or sub-pixel rendering on Mac, but generally I'd say it defaults to replicating the platform's native way of rendering fonts.

raphlinus · 2022-11-17T14:44:58Z

Blurry text is tracked in linebender/glazier#26, it's a DPI scaling problem.

Regarding glyph rendering, that is a question for piet-gpu, and a very interesting one. I just wrote linebender/vello#204 to capture my current thoughts. It's subject to discussion, and may well affect a decision of when and whether to depend on this stack.

This is a mostly working button implementation, but the background (a gradient) isn't rendering yet. When it is, I'll likely merge the PR.

This adds the rendering of the gradient to the button widget. The "piet_scene_helpers" module is a bit hacky, we'll need to have some discussions about how to handle kurbo shape types more easily. But it should work for now.

Psykopear · 2022-11-21T19:22:01Z

Trying this on Linux with Gnome/Wayland.

The main.rs runs, I see the button with the gradient background, but if I click on it I get no message on stdout.
I can't close the window normally (x button or shortcut to close window) I have to ctrl+c from the terminal.

edit: It was running on wayland but as an X client, if I try to run with "wayland" feature on glazier it panics:

    Finished release [optimized] target(s) in 0.07s
     Running `target/release/xilem`
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', /home/docler/repos/xilem/src/app.rs:205:24
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
[wayland-client error] A handler for wl_pointer panicked.
fish: Job 1, 'cargo run --release' terminated by signal SIGABRT (Abort)
xilem on new_infra is 📦 v0.1.0 via 🦀 v1.65.0 took 4s x

raphlinus · 2022-11-21T19:33:18Z

Thanks for trying it! I haven't tested on anything but mac yet. The lack of mouse sensitivity sounds like a problem, we'll need to investigate it.

I'm not sure what exactly is wrong with quitting, that appears to be a glazier issue (the code in xilem is adding the quit item to the menu).

The panic on Wayland looks similar to this observation. Again I think the best place to fix this is glazier.

Psykopear · 2022-11-21T19:35:21Z

Right, I also get no menu, so maybe that's related, but I see no logs in the console that could help:

Edit: Running the glazier example I see that menus are not implemented yet, so that's not an issue with this PR.

2022-11-21T19:39:44.889418Z  WARN glazier::backend::x11::menu: Menu::new is currently unimplemented for X11 backend.
2022-11-21T19:39:44.889459Z  WARN glazier::backend::x11::menu: Menu::add_item is currently unimplemented for X11 backend.
2022-11-21T19:39:44.889471Z  WARN glazier::backend::x11::menu: Menu::add_item is currently unimplemented for X11 backend.
2022-11-21T19:39:44.889476Z  WARN glazier::backend::x11::menu: Menu::add_item is currently unimplemented for X11 backend.
2022-11-21T19:39:44.889481Z  WARN glazier::backend::x11::menu: Menu::new is currently unimplemented for X11 backend.
2022-11-21T19:39:44.889485Z  WARN glazier::backend::x11::menu: Menu::new is currently unimplemented for X11 backend.
2022-11-21T19:39:44.889496Z  WARN glazier::backend::x11::menu: Menu::add_dropdown is currently unimplemented for X11 backend.
2022-11-21T19:39:44.889503Z  WARN glazier::backend::x11::menu: Menu::add_dropdown is currently unimplemented for X11 backend.

DJMcNab · 2022-11-21T20:00:56Z

Testing on Windows 10 with AMD Ryzen 3600 and GTX 1050ti, leads to the window not responding before I can take any actions.
Running the file in a debugger gives a few observations:
Building the window takes quite a while. Showing the window is instant, but once the window is shown we never get to app_main:83. I.e. something in window.show() hangs. This appears to be UpdateWindow.
My best guess is that UpdateWindow is waiting for the messages to be processed, which can't happen because the thread is waiting for them.
Bizarrely, the first frame? is drawn, despite this.

raphlinus · 2022-11-21T22:57:14Z

I've tested the glazier-shello example on Windows, but not the integration with piet-gpu. Unfortunately, I'm at the office right now without easy access to a Windows machine. I can take another look when I get home.

raphlinus · 2022-11-22T02:00:52Z

I do repro the "render one frame then hang" behavior with Windows, and also note that it's the same with glazier-shello. This is very likely a glazier problem and I can probably track it down.

Small update: https://github.com/dfrg/piet-gpu/tree/dshell/examples/shello had this working correctly on Windows (using the unpiet branch of druid-shell), and something broke along the way to the latter becoming glazier. It should be possible to track down either through looking at what changed, or debugging the current state.

raphlinus · 2022-11-22T05:51:56Z

The Windows hang is fixed by linebender/vello#207. The reason the shello example worked is that the branch predated the robust memory work. So this was not in fact a glazier problem.

jplatte · 2022-11-22T09:12:08Z

On actual wayland (glazier/wayland feature), I got a panic (and transparent window):

thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', /home/jplatte/code/xilem/src/app.rs:205:47
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
[wayland-client error] A handler for wl_pointer panicked.

With the gtk feature, glazier didn't compile at all.

Allow selecting the glazier backend on Linux

jplatte · 2022-11-22T15:39:36Z

It wasn't my intention to get my PR merged into this one without Raph's consent, so in case that is unwanted, please just force-push away and I'll re-open / re-create my PR after this is done.

raphlinus · 2022-11-22T15:49:58Z

No worries, it's all good. Very likely it'll be helpful for fixing and validating the panic on Wayland, which I intend to do later today.

src/render.rs

Should fix crashes on Wayland in particular. Also snap to newer deps, which should fix hang on Vulkan.

raphlinus · 2022-11-22T21:40:00Z

We should now be able to handle window events before the first paint. Also I snapped Cargo.lock to newer github versions. There's lots to do still (including some work on dpi that I'm seeing), but I'm wondering if this might now be "good enough" to merge, and future work on top of it.

flxzt · 2022-11-22T22:45:16Z

I have an eGPU ( Nvidia GTX 1080 ) I can connect to my laptop (Intel HD graphics) so I am able to test a couple of different configurations:

with X11 and nvidia: It runs, but panics as soon as I try to resize the window:
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: ERROR_OUT_OF_DATE_KHR', src/render.rs:118:18
with X11 / xwayland and integrated graphics: the window stays black and I can only quit with Ctrl+C in the terminal
with wayland and integrated graphics: Transparent window..

hope this helps. on windows it runs now for me!

raphlinus · 2022-11-22T22:50:33Z

Thanks for the reports. We're going to switch to wgpu soonish, so it doesn't make sense to go too deep into compatibility issues just now, though it would make sense to fix obvious breakage.

Psykopear · 2022-11-23T08:07:07Z

Ok, now the x11 backend works. It takes some time (~1 second) to get from window creation to the button appearing, but then both the button and closing the window work.

With the wayland backend, I get an invisible window and no logs in stdout. But, if I hit the shortcut to close the window, it quits correctly.

Same behaviour with intel integrated and rtx3050

dfrg

Excited to land this!

raphlinus force-pushed the new_infra branch from fe5ad3d to 2280e9e Compare November 16, 2022 22:07

DJMcNab added a commit that referenced this pull request Nov 16, 2022

Create initial CI

a4f6763

I've chosen not to deny warnings in CI because we currently have warnings. Once #1 lands, we can enforce cleanliness of warnings

DJMcNab mentioned this pull request Nov 16, 2022

Create initial CI #2

Merged

DJMcNab mentioned this pull request Nov 17, 2022

FPS drops in scroll example #3

Closed

raphlinus mentioned this pull request Nov 17, 2022

Plan for glyph rendering linebender/vello#204

Open

raphlinus and others added 3 commits November 20, 2022 22:03

Clickable button

c0c450c

This is a mostly working button implementation, but the background (a gradient) isn't rendering yet. When it is, I'll likely merge the PR.

Merge branch 'main' into new_infra

209fd9d

Button gradient background

09038d9

This adds the rendering of the gradient to the button widget. The "piet_scene_helpers" module is a bit hacky, we'll need to have some discussions about how to handle kurbo shape types more easily. But it should work for now.

raphlinus marked this pull request as ready for review November 21, 2022 18:17

raphlinus mentioned this pull request Nov 21, 2022

Quit menu isn't enabled linebender/glazier#30

Open

raphlinus mentioned this pull request Nov 21, 2022

Order of events on window creation linebender/glazier#31

Open

Allow selecting the glazier backend on Linux

4ca1625

jplatte mentioned this pull request Nov 22, 2022

Allow selecting the glazier backend on Linux #4

Merged

Merge pull request #4 from linebender/jplatte/backend-selection

44a70d7

Allow selecting the glazier backend on Linux

Psykopear reviewed Nov 22, 2022

View reviewed changes

src/render.rs Show resolved Hide resolved

Be more robust to event order

36cd3c5

Should fix crashes on Wayland in particular. Also snap to newer deps, which should fix hang on Vulkan.

dfrg mentioned this pull request Nov 23, 2022

Update piet-scene to depend on peniko linebender/vello#208

Merged

dfrg approved these changes Nov 23, 2022

View reviewed changes

raphlinus merged commit ef1d907 into main Nov 23, 2022

DJMcNab deleted the new_infra branch November 23, 2022 18:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Work in progress xilem prototype #1

Work in progress xilem prototype #1

raphlinus commented Nov 16, 2022

ghost commented Nov 17, 2022

dzhou121 commented Nov 17, 2022 •

edited

Loading

ghost commented Nov 17, 2022 •

edited by ghost

Loading

dzhou121 commented Nov 17, 2022

ghost commented Nov 17, 2022 •

edited by ghost

Loading

raphlinus commented Nov 17, 2022

Psykopear commented Nov 21, 2022 •

edited

Loading

raphlinus commented Nov 21, 2022

Psykopear commented Nov 21, 2022 •

edited

Loading

DJMcNab commented Nov 21, 2022

raphlinus commented Nov 21, 2022

raphlinus commented Nov 22, 2022 •

edited

Loading

raphlinus commented Nov 22, 2022

jplatte commented Nov 22, 2022

jplatte commented Nov 22, 2022

raphlinus commented Nov 22, 2022

raphlinus commented Nov 22, 2022

flxzt commented Nov 22, 2022 •

edited

Loading

raphlinus commented Nov 22, 2022

Psykopear commented Nov 23, 2022

dfrg left a comment

Work in progress xilem prototype #1

Work in progress xilem prototype #1

Conversation

raphlinus commented Nov 16, 2022

ghost commented Nov 17, 2022

dzhou121 commented Nov 17, 2022 • edited Loading

ghost commented Nov 17, 2022 • edited by ghost Loading

dzhou121 commented Nov 17, 2022

ghost commented Nov 17, 2022 • edited by ghost Loading

raphlinus commented Nov 17, 2022

Psykopear commented Nov 21, 2022 • edited Loading

raphlinus commented Nov 21, 2022

Psykopear commented Nov 21, 2022 • edited Loading

DJMcNab commented Nov 21, 2022

raphlinus commented Nov 21, 2022

raphlinus commented Nov 22, 2022 • edited Loading

raphlinus commented Nov 22, 2022

jplatte commented Nov 22, 2022

jplatte commented Nov 22, 2022

raphlinus commented Nov 22, 2022

raphlinus commented Nov 22, 2022

flxzt commented Nov 22, 2022 • edited Loading

raphlinus commented Nov 22, 2022

Psykopear commented Nov 23, 2022

dfrg left a comment

Choose a reason for hiding this comment

dzhou121 commented Nov 17, 2022 •

edited

Loading

ghost commented Nov 17, 2022 •

edited by ghost

Loading

ghost commented Nov 17, 2022 •

edited by ghost

Loading

Psykopear commented Nov 21, 2022 •

edited

Loading

Psykopear commented Nov 21, 2022 •

edited

Loading

raphlinus commented Nov 22, 2022 •

edited

Loading

flxzt commented Nov 22, 2022 •

edited

Loading