Alternative scrollview implementation (doesn't use "origin" for scroll offset) #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Philipp-M
approved these changes
Dec 6, 2023
| let child_size = self.child.layout(cx, child_proposed); | ||
| Size::new(child_size.width, proposed_size.height) | ||
| fn layout(&mut self, cx: &mut LayoutCx, bc: &BoxConstraints) -> Size { | ||
| cx.request_paint(); |
There was a problem hiding this comment.
Is this necessary even, when the layout hasn't changed at all?
(I see this is done in other widgets as well though, maybe a point to keep in mind later for optimization etc.)
There was a problem hiding this comment.
I'm not sure if this is the best way of doing it. But I was seeing the visual rendering on screen failing to update properly before I put this in.
nicoburns
force-pushed
the
scrollview-without-origin
branch
from
991a346
to
c55d3e9
Compare
Co-authored-by: Kaur Kuut <strom@nevermore.ee> Co-authored-by: Philipp Mildenberger <philipp@mildenberger.me>
xorgy
force-pushed
the
scrollview-without-origin
branch
from
c55d3e9
to
b9eaabd
Compare
|
I've updated this to work against the upstream enumerated wheel delta type. The medium term idea is that general purpose scroll gestures will eventually be abstracted into the platform, because they will become rather complex when we start implementing kinetic scrolling (on platforms where it doesn't come for free) and touchscreen scrolling. |
xorgy
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.