Log management #237
Merged
Log management #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sentential[bot] <bot@sentential>
bkeane
reviewed
Mar 12, 2023
| @@ -51,8 +61,12 @@ def test_deploy_w_provisions( | |||
|
|
|||
| image = aws_ecr_driver.get_image("0.0.1") | |||
| aws_lambda_driver.deploy(image, Architecture.system()) | |||
| self.create_log_group( | |||
| aws_lambda_driver.log_group | |||
| ) # Is this something that moto should be doing? | |||
There was a problem hiding this comment.
https://docs.getmoto.org/en/latest/docs/services/cloudwatch.html
If it isn't exploding there's a good chance moto is handling this. The clients singleton all but ensures this. During test, everything is fed the test config and cannot escape moto.
There was a problem hiding this comment.
Unrelated follow up:
In my readings this way of doing the clients is an anti-pattern. It's sort of a poor-mans dependency injection.
The thing is, in my explorations of "proper" solutions, I came to feel that the medicine was worse than the disease.
Am I right? 🤷♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.