linera-views::dynamodb: box aws-sdk-dynamodb futures
#1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twey
force-pushed
the
04-01-Box_DynamoDB_futures
branch
from
4952dc2
to
7662d87
Compare
Twey
changed the title
linera-views: box aws_sdk_dynamodb futureslinera-views::dynamodb: box aws-sdk-dynamodb futures
ma2bd
approved these changes
Apr 2, 2024
afck
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The futures returned by
aws-sdk-dynamodbare large, and frequently lead to stack overflow inlinera-views::dynamodb.Proposal
Box them using
futures::FutureExt::boxedto move them to the heap beforeawaiting them.Test Plan
CI.
Release Plan
No user-visible changes.
Links