Remove the OracleRecord and OracleResponses types; never throw away responses. #2232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathieuDutSik
pushed a commit
to MathieuDutSik/linera-protocol_second
that referenced
this pull request
Jul 12, 2024
…esponses. (linera-io#2232) * Remove the OracleRecord type. * Don't throw away returned oracle responses. * Remove the OracleResponses type. * Ensure matching block execution outcomes, including oracle responses. * Fix tests; add an oracle entry also for rejected messages.
This was referenced Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
OracleResponsesandOracleRecordtypes were just wrappers for iterators or vectors of responses, and are not really needed. The former was also a source of potential bugs: When replaying, we still want to return the replayed oracle responses together with the execution outcomes, so they end up in theExecutedBlock. Also, when executing a system operation that created an application, we should still preserve the oracle responses returned by the initial system operation, rather than overwriting them with the ones from the contract initialization. (This potential bug didn't manifest itself yet, since so far no system operation both uses an oracle and creates an application.)Proposal
Remove the two types, and fix the potential issues.
Test Plan
I changed the assertion in
process_confirmed_blockto compare not only the state hash and the outgoing messages, but also the oracle responses, i.e. the complete block execution outcome.I tried locally that without this fix, but with the assertion,
test_memory_run_application_with_dependencyfails.Links