Update lint nightly to 2024-07-11 #2235
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afck
approved these changes
Jul 13, 2024
| @@ -55,14 +55,15 @@ use { | |||
|
|
|||
| /// We implement two types: | |||
| /// 1) The first type KeyValueStoreView implements View and the function of KeyValueStore | |||
| /// (though not KeyValueStore). | |||
| /// (though not KeyValueStore). | |||
There was a problem hiding this comment.
(Not related to this PR, but there are some backticks missing in this file.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently our lint toolchain (a nightly) is lagging behind our build toolchain (stable). This means that some features we can use in the codebase won't be able to pass linting.
Also enables several helpful checks, including for missing Cargo features.
Proposal
Update the lint toolchain to use nightly Rust 2024-07-11. Update
cfg-aliasesto not warn with it.Test Plan
None required: this change primarily affects our linting process.
Release Plan
None required.
Links