LLS: Some edits for the LLS GUI #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| class GenericAbsSystem(AbsSystem): | ||
| """Class for Generic Absorption Line System | ||
| """ | ||
| def __init__(self, radec, zabs, vlim, **kwargs): | ||
| if vlim is None: | ||
| if vlim is None: |
|
Fixed. Anything else? |
| class GenericAbsSystem(AbsSystem): | ||
| """Class for Generic Absorption Line System | ||
| """ | ||
| def __init__(self, radec, zabs, vlim, **kwargs): | ||
| if vlim is None: | ||
| vlim = [-500.,500.]*u.km/u.s |
There was a problem hiding this comment.
I'm still thinking whether this is a good idea or not. If you do something like this for vlim, then for the sake of symmetry I would also allow radec and zabs to have default values, which may be useful in some cases where you do not care about those quantities. On the other hand, for the cases you do care, having default values may cause some trouble...
There was a problem hiding this comment.
How about having them as optional parameters?
There was a problem hiding this comment.
Yeah, fair point.
I'll go back to what we had.
ntejos
added a commit
that referenced
this pull request
Dec 3, 2015
LLS: Some edits for the LLS GUI Looks good to me then. Merging.
|
Changes Unknown when pulling f8772d8 on profxj:LLS into ** on linetools:master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new method or two
and a test