-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write EW on stack_plot in plots.py #402
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few edits to make
linetools/analysis/plots.py
Outdated
ewval = '{:05.2f}'.format(iline.attrib['EW'].value) | ||
ewsigval = '{:05.2f}'.format(iline.attrib['sig_EW'].value) | ||
compsign = ' = ' | ||
if iline.analy['flg_eye'] == 1: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also show as an upper limit if EW < 3*sig_EW
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And in this case, have the value reported be 2*sig_EW
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
linetools/analysis/plots.py
Outdated
if add_ew: | ||
ewval = '{:05.2f}'.format(iline.attrib['EW'].value) | ||
ewsigval = '{:05.2f}'.format(iline.attrib['sig_EW'].value) | ||
compsign = ' = ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe remove the spaces here to pack the text in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Looks good. Am approving and will merge. |
No description provided.