Cleaner look for lt_radec #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntejos
reviewed
Sep 21, 2017
linetools/scripts/lt_radec.py
Outdated
| @@ -43,10 +43,15 @@ def main(args=None): | |||
| coord = ltu.radec_to_coord(icoord) | |||
|
|
|||
| # Time to print | |||
| print('===================================') | |||
| print('J{:s}{:s}'.format(coord.ra.to_string(unit=u.hour,sep='',pad=True), | |||
There was a problem hiding this comment.
I would remove this "===== ..." header, as no every terminal has monospace fonts.
There was a problem hiding this comment.
changed to a blank line (helps to have that separation)
linetools/scripts/lt_radec.py
Outdated
| print('J{:s}{:s}'.format(coord.ra.to_string(unit=u.hour,sep='',pad=True), | ||
| coord.dec.to_string(sep='',pad=True,alwayssign=True))) | ||
| print(' ') | ||
| print(' {:s} {:s}'.format(coord.ra.to_string(unit=u.hour,sep=':',pad=True), | ||
| coord.dec.to_string(sep=':',pad=True,alwayssign=True))) |
There was a problem hiding this comment.
Say explicitly that these are J2000 coordinates somewhere?
There was a problem hiding this comment.
added. good suggestion.
|
merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As advertised.
Small changes for a somewhat cleaner look.