lt_xspec: Auto z and more #417
Conversation
There was a problem hiding this comment.
A couple things that may or may not be bugs, one regarding multiple spectra. If you don't intend to address this behavior on the current PR, it's fine. The second bug (linelists) actually negates the added feature somewhat, so we should try and get it straightened out.
| # Reset redshift from spec | ||
| if zsys is None: | ||
| if hasattr(self.spec_widg.spec, 'z'): | ||
| self.pltline_widg.setz(str(self.spec_widg.spec.z[self.spec_widg.select])) |
There was a problem hiding this comment.
I tried this feature out with spectra from a specdb.spectra_from_coord() query, and the first spectrum has its redshift set, but the redshift does not change when I select a different spectrum. Can the multiSpecWidget talk back to the main gui to change redshift when selecting different spectra?
| self.pltline_widg.llist['Plot'] = True | ||
| idx = self.pltline_widg.lists.index(self.pltline_widg.llist['List']) | ||
| self.pltline_widg.llist_widget.setCurrentRow(idx) | ||
| # |
There was a problem hiding this comment.
Loading up the GUI automatically selects the correct linelist for 'Galaxy', but the lines do not immediately show. Instead, I have a click on a different linelist in this widget then then back to Galaxy. At that point, I see the galaxy lines plotted. This is quite possibly a Qt 'idiosyncracy' and perhaps works properly on other platforms. Are the lines marked when you open up the GUI on your machine?
There was a problem hiding this comment.
nope, it is an idiosyncracy..
| @@ -86,7 +98,8 @@ def __init__(self, ispec, parent=None, zsys=None, norm=None, exten=None, | |||
|
|
|||
| # Extras | |||
| extras = QWidget() | |||
| extras.setMaximumWidth(130*self.scale) | |||
| extras.setMinimumWidth(180*self.scale) | |||
| extras.setMaximumWidth(280*self.scale) | |||
| @@ -7,3 +7,4 @@ v1.1 | |||
| Adding in X-ray lines to EUV | |||
| v1.2 | |||
| Adding some extra forbidden lines for Galaxy (NT Jun 28, 2017) | |||
| Turned off distracting higher order Balmer lines in Galaxy | |||
There was a problem hiding this comment.
Once again, thanks! Much cleaner for higher-z galaxies.
|
Is this ready, @jnburchett ? |
Loads linelist and redshift if
.z and .type='galaxy' in spectrum object.