Transition lookup by Zion tuple #422
Conversation
linetools/lists/linelist.py
Outdated
| @@ -595,6 +597,9 @@ def all_transitions(self, line, debug=False): | |||
| elif isinstance(line, Quantity): # Rest wavelength (with units) | |||
| data = self.__getitem__(line) | |||
| return self.all_transitions(data['name']) | |||
| elif isinstance(line, tuple): # Zion input | |||
| data = self.__getitem__(line) | |||
| return self.all_transitions(data['name'][0].split(' ')[0]) | |||
There was a problem hiding this comment.
This seems duplication of code. You could simply replace current line 597:
elif isinstance(line, Quantity): -> elif isinstance(line, (tuple, Quantity)):.
There was a problem hiding this comment.
Fair enough, but then I still have test whether 'line' is a tuple because of the differences between lines 599 and 602.
There was a problem hiding this comment.
The spliting of name should be done in current line 596...
There was a problem hiding this comment.
Only if all_transitions returns just 1 transition...
There was a problem hiding this comment.
Oh, I see. I would prefer avoid duplication of code, so maybe the solution is to have the code check whether the output is dict (implying 1 transition) or Table (implying >1 transition).
|
Yup
…On Thu, Oct 19, 2017, 14:52 jnburchett ***@***.***> wrote:
We cool, @profxj <https://github.com/profxj> and @ntejos
<https://github.com/ntejos> ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#422 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AD0BjVhHXso63bnmt8yI70HYAr8EtJhrks5st8SwgaJpZM4P9BVh>
.
|
|
The other examples around it are MgII, CIII, and HI!!! I'm merging. |
Make LineList.all_transitions and LineList.strongest_transitions accept Zion tuple, e.g., (8,6)