Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix for Gaussian in spec_widgets #426

Merged
merged 2 commits into from
Nov 11, 2017
Merged

Small fix for Gaussian in spec_widgets #426

merged 2 commits into from
Nov 11, 2017

Conversation

profxj
Copy link
Contributor

@profxj profxj commented Oct 26, 2017

As titled.

Deals with units

@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.875% when pulling 76474b9 on ltxspec_wo_sig into 0b21274 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 71.86% when pulling aa2af51 on ltxspec_wo_sig into 0b21274 on master.

@@ -420,7 +422,7 @@ def on_key(self, event):
# Message
mssg = 'Gaussian Fit: '
mssg = mssg+' :: Mean={:g}, Amplitude={:g}, sigma={:g}, flux={:g}'.format(
parm.mean.value, parm.amplitude.value, parm.stddev.value, flux)
parm.mean.value*self.spec.wavelength.unit, parm.amplitude.value, parm.stddev.value*self.spec.wavelength.unit, flux)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line really cut off, or is self.spe a typo?

Copy link
Collaborator

@jessicawerk jessicawerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Collaborator

@jessicawerk jessicawerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay!

@jessicawerk
Copy link
Collaborator

Ready to go...

@jessicawerk jessicawerk reopened this Nov 11, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 71.86% when pulling aa2af51 on ltxspec_wo_sig into 0b21274 on master.

@jessicawerk jessicawerk merged commit 8620be3 into master Nov 11, 2017
@profxj profxj deleted the ltxspec_wo_sig branch November 27, 2017 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants