-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional options for continuum fit #499
Conversation
…t - added some docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok overall but the code needs to be more Pythonic.
- Replaced the two nested for loops with one for loop and np.max. The code is now faster
…The code is also faster now. Tested on two examples before and after changes, and the outputs look the same.
Addressed all requested changes for now. |
…he intervals that define continuum
Thanks for this @marijana777 . |
Example spectrum was generated by adding a few Gaussian absorptions to a constant flux and then adding noise.
Thank you @profxj for the comments. Just added the test of the contknots method |
This all looks good now @marijana777 |
Ok, @marijana777 pull in |
@profxj confirming that Travis passed on test_continuumfnd.py in all cases. I also confirmed that the rest of the Travis output seems almost the same as in the most recent merged PR at this moment (i.e., the same tests failed, etc). |
Adding options to: