Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small edits for PypeIt compatability #506

Merged
merged 6 commits into from Aug 23, 2019
Merged

Small edits for PypeIt compatability #506

merged 6 commits into from Aug 23, 2019

Conversation

profxj
Copy link
Contributor

@profxj profxj commented Aug 3, 2019

As titled.

No new tests or docs

@coveralls
Copy link

coveralls commented Aug 3, 2019

Coverage Status

Coverage decreased (-0.005%) to 71.461% when pulling c2f064f on for_pypeit into 70e2829 on master.

@profxj profxj requested a review from ntejos August 22, 2019 13:27
@profxj profxj requested review from jnburchett and removed request for ntejos August 23, 2019 23:08
@profxj
Copy link
Contributor Author

profxj commented Aug 23, 2019

Also has a bug fix for the stack plot test (the last PR tripped it and
I didn't notice).

Copy link
Collaborator

@jnburchett jnburchett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough!

@@ -28,6 +28,7 @@
zero_coord = SkyCoord(ra=0.*u.deg, dec=0.*u.deg) # Coords
init_analy = {
'spec': None, # Analysis inputs (e.g. spectrum; from .clm file or AbsID)
'spec_file': '', # Spectrum file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't there already?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oddly, no.

@profxj
Copy link
Contributor Author

profxj commented Aug 23, 2019

merging.

@profxj profxj merged commit d6d9e66 into master Aug 23, 2019
@profxj profxj deleted the for_pypeit branch August 23, 2019 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants