New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select filters (in filter dialog) for categorical columns does not work #16

Closed

thinkh opened this issue Jun 1, 2018 · 3 comments

Assignees

Labels

bug

Member

thinkh commented Jun 1, 2018

Release number or git hash: https://www.npmjs.com/package/lineupjs/v/3.0.1-beta.12
Web browser version and OS: Chrome 67 beta

Steps to reproduce

Open https://lineup.js.org/app/#soccer
Click on filter icon for a categorical column
Uncheck the first check mark
Try to check selected categories

Observed behavior

Unable to check/uncheck filter
The first two rows should do the same, don't they?

Expected behavior

Remove the first row and keep Un/Select All or add a label to the first row
Check/uncheck categories should work

thinkh mentioned this issue

Select filters (in filter dialog) for categorical columns does not work lineupjs/lineupjs#17

Closed

sgratzl added the bug label

Member Author

thinkh commented Jul 5, 2018 •

edited

@sgratzl Can you please have a look for a fix? We need this functionality for the user study.

Member

sgratzl commented Jul 5, 2018

part of
be48b68
lineupjs/lineupjs@a8e7b33

sgratzl closed this as completed

sgratzl self-assigned this

Member Author

thinkh commented Jul 9, 2018

Thanks. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment