Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select filters (in filter dialog) for categorical columns does not work #17

Closed
thinkh opened this issue May 30, 2018 · 2 comments
Closed
Labels
type: bug Something isn't working

Comments

@thinkh
Copy link
Member

thinkh commented May 30, 2018

Steps to reproduce

  1. Open https://lineup.js.org/app/#soccer
  2. Click on filter icon for a categorical column
  3. Uncheck the first check mark
  4. Try to check selected categories

Observed behavior

  • Unable to check/uncheck filter
  • The first two rows should do the same, don't they?

lineup-filter-category-dialog

Expected behavior

  • Remove the first row and keep Un/Select All or add a label to the first row
  • Check/uncheck categories should work
@sgratzl
Copy link
Member

sgratzl commented Jun 1, 2018

works in regular lineup. thus not a lineupjs bug

filter

@sgratzl sgratzl closed this as completed Jun 1, 2018
@sgratzl sgratzl added invalid type: bug Something isn't working labels Jun 1, 2018
@thinkh
Copy link
Member Author

thinkh commented Jun 1, 2018

Moved to lineupjs/lineup_app#16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants