proper clean up value cache

lineupjs · Dec 19, 2018 · 24833d1 · 24833d1
1 parent daa746d
commit 24833d1
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/src/provider/DirectRenderTasks.ts b/src/provider/DirectRenderTasks.ts
@@ -22,10 +22,13 @@ export class DirectRenderTasks extends ARenderTasks implements IRenderTaskExectu
   setData(data: IDataRow[]) {
     this.data = data;
     this.cache.clear();
+    this.valueCacheData.clear();
   }
 
 
   dirtyColumn(col: Column, type: 'data' | 'summary' | 'group') {
+    super.dirtyColumn(col, type);
+
     if (type === 'group') {
       return; // not cached
     }

diff --git a/src/provider/ScheduledTasks.ts b/src/provider/ScheduledTasks.ts
@@ -29,6 +29,7 @@ export class ScheduleRenderTasks extends ARenderTasks implements IRenderTaskExec
   }
 
   dirtyColumn(col: Column, type: 'data' | 'group' | 'summary') {
+    super.dirtyColumn(col, type);
     // order designed such that first groups, then summaries, then data is deleted
 
     for (const key of Array.from(this.cache.keys()).sort()) {
@@ -84,7 +85,7 @@ export class ScheduleRenderTasks extends ARenderTasks implements IRenderTaskExec
     }
 
     for (const col of cols) {
-      this.valueCacheData.delete(col.id);
+      super.dirtyColumn(col, type);
       this.workers.deleteRef(col.id);
     }
   }

diff --git a/src/provider/tasks.ts b/src/provider/tasks.ts
@@ -270,6 +270,12 @@ export class ARenderTasks {
     return this.builderForEach(b, order, (i: number) => col.iterCategory(this.data[i]), build);
   }
 
+  dirtyColumn(col: Column, type: 'data' | 'summary' | 'group') {
+    if (type !== 'data') {
+      return;
+    }
+    this.valueCacheData.delete(col.id);
+  }
 
   protected setValueCacheData(key: string, value: Float32Array | UIntTypedArray | Int32Array | null) {
     if (value == null) {