closes #161 sort groups similar to sort values

lineupjs · Mar 25, 2020 · 6da170f · 6da170f
1 parent 6f83c31
commit 6da170f
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/model/internalCategorical.ts b/src/model/internalCategorical.ts
@@ -100,16 +100,16 @@ export function toMostFrequentCategoricals(rows: ISequence<IDataRow>, col: ICate
 /** @internal */
 export function toGroupCompareCategoryValue(rows: ISequence<IDataRow>, col: ICategoricalColumn, valueCache?: ISequence<ICategory | null>): ICompareValue[] {
   if (isSeqEmpty(rows)) {
-    return [NaN, 0];
+    return [NaN, null]
   }
   const mostFrequent = findMostFrequent(rows.map((d) => col.getCategory(d)), valueCache);
   if (mostFrequent.cat == null) {
-    return [NaN, 0];
+    return [NaN, null];
   }
-  return [mostFrequent.cat.value, mostFrequent.count];
+  return [mostFrequent.cat.value, mostFrequent.cat.name.toLowerCase()];
 }
 
-export const COMPARE_GROUP_CATEGORY_VALUE_TYPES = [ECompareValueType.FLOAT, ECompareValueType.COUNT];
+export const COMPARE_GROUP_CATEGORY_VALUE_TYPES = [ECompareValueType.FLOAT, ECompareValueType.STRING];
 
 /** @internal */
 function compareCategory(a: ICategory | null, b: ICategory | null) {