filter live previews updates

lineupjs · Mar 20, 2020 · 6e93359 · 6e93359
1 parent e69e441
commit 6e93359
Show file tree

Hide file tree

Showing 11 changed files with 19 additions and 15 deletions.
diff --git a/src/config.ts b/src/config.ts
@@ -92,9 +92,9 @@ export interface ILineUpOptions {
 
   /**
    * flag whether to shows filter previews as soon as the user changes the filter in the dialog
-   * @default false
+   * @default ['filter', 'vis']
    */
-  liveFilterPreviews: boolean;
+  livePreviws: ('search' | 'filter' | 'vis')[];
 
   /**
    * option to specify the default slope graph mode
@@ -209,7 +209,7 @@ export function defaultOptions(): ITaggleOptions {
     defaultSlopeGraphMode: 'item',
     overviewMode: false,
 
-    liveFilterPreviews: false,
+    livePreviws: ['filter', 'vis'],
     onDialogBackgroundClick: 'cancel',
 
     rowHeight: 18,

diff --git a/src/ui/EngineRenderer.ts b/src/ui/EngineRenderer.ts
@@ -50,7 +50,7 @@ export default class EngineRenderer extends AEventDispatcher {
 
     const dialogManager = new DialogManager({
       doc: parent.ownerDocument!,
-      liveFilterPreviews: options.liveFilterPreviews,
+      livePreviews: options.livePreviws,
       onDialogBackgroundClick: options.onDialogBackgroundClick,
     });
 

diff --git a/src/ui/dialogs/BooleanFilterDialog.ts b/src/ui/dialogs/BooleanFilterDialog.ts
@@ -10,7 +10,7 @@ export default class BooleanFilterDialog extends ADialog {
 
   constructor(private readonly column: BooleanColumn, dialog: IDialogContext) {
     super(dialog, {
-      livePreview: dialog.manager.liveFilterPreviews
+      livePreview: dialog.manager.livePreviews.includes('filter')
     });
     this.before = this.column.getFilter();
   }

diff --git a/src/ui/dialogs/CategoricalFilterDialog.ts b/src/ui/dialogs/CategoricalFilterDialog.ts
@@ -12,7 +12,7 @@ export default class CategoricalFilterDialog extends ADialog {
 
   constructor(private readonly column: CategoricalColumn | SetColumn, dialog: IDialogContext) {
     super(dialog, {
-      livePreview: dialog.manager.liveFilterPreviews
+      livePreview: dialog.manager.livePreviews.includes('filter')
     });
     this.before = this.column.getFilter() || {filter: this.column.categories.map((d) => d.name), filterMissing: false};
   }

diff --git a/src/ui/dialogs/CategoricalMappingFilterDialog.ts b/src/ui/dialogs/CategoricalMappingFilterDialog.ts
@@ -13,7 +13,7 @@ export default class CategoricalMappingFilterDialog extends ADialog {
 
   constructor(private readonly column: OrdinalColumn, dialog: IDialogContext) {
     super(dialog, {
-      livePreview: dialog.manager.liveFilterPreviews
+      livePreview: dialog.manager.livePreviews.includes('filter')
     });
     this.before = this.column.getFilter() || {filter: this.column.categories.map((d) => d.name), filterMissing: false};
   }

diff --git a/src/ui/dialogs/ChangeRendererDialog.ts b/src/ui/dialogs/ChangeRendererDialog.ts
@@ -8,7 +8,9 @@ export default class ChangeRendererDialog extends ADialog {
   private readonly before: {renderer: string, group: string, summary: string};
 
   constructor(private readonly column: Column, dialog: IDialogContext, private readonly ctx: IRankingHeaderContext) {
-    super(dialog);
+    super(dialog, {
+      livePreview: dialog.manager.livePreviews.includes('vis')
+    });
 
     this.before = {
       renderer: column.getRenderer(),

diff --git a/src/ui/dialogs/DateFilterDialog.ts b/src/ui/dialogs/DateFilterDialog.ts
@@ -12,7 +12,7 @@ export default class DateFilterDialog extends ADialog {
 
   constructor(private readonly column: DateColumn, dialog: IDialogContext) {
     super(dialog, {
-      livePreview: dialog.manager.liveFilterPreviews
+      livePreview: dialog.manager.livePreviews.includes('filter')
     });
     this.before = this.column.getFilter() || noDateFilter();
   }

diff --git a/src/ui/dialogs/DialogManager.ts b/src/ui/dialogs/DialogManager.ts
@@ -12,12 +12,12 @@ export default class DialogManager {
 
   private readonly openDialogs: ADialog[] = [];
   readonly node: HTMLElement;
-  readonly liveFilterPreviews: boolean;
+  readonly livePreviews: string[];
   readonly onDialogBackgroundClick: 'cancel' | 'confirm';
 
-  constructor(options: {doc: Document, liveFilterPreviews: boolean, onDialogBackgroundClick: 'cancel' | 'confirm'}) {
+  constructor(options: {doc: Document, livePreviews: string[], onDialogBackgroundClick: 'cancel' | 'confirm'}) {
     const doc = options.doc;
-    this.liveFilterPreviews = options.liveFilterPreviews;
+    this.livePreviews = options.livePreviews;
     this.onDialogBackgroundClick = options.onDialogBackgroundClick;
     this.node = doc.createElement('div');
     this.node.classList.add(cssClass('backdrop'));

diff --git a/src/ui/dialogs/NumberFilterDialog.ts b/src/ui/dialogs/NumberFilterDialog.ts
@@ -11,7 +11,7 @@ export default class NumberFilterDialog extends ADialog {
 
   constructor(private readonly column: IMapAbleColumn, dialog: IDialogContext, private readonly ctx: IRankingHeaderContext) {
     super(dialog, {
-      livePreview: dialog.manager.liveFilterPreviews
+      livePreview: dialog.manager.livePreviews.includes('filter')
     });
 
     this.before = column.getFilter();

diff --git a/src/ui/dialogs/SearchDialog.ts b/src/ui/dialogs/SearchDialog.ts
@@ -7,7 +7,9 @@ import {cssClass} from '../../styles';
 export default class SearchDialog extends ADialog {
 
   constructor(private readonly column: Column, dialog: IDialogContext, private readonly provider: IDataProvider) {
-    super(dialog);
+    super(dialog, {
+      livePreview: dialog.manager.livePreviews.includes('search')
+    });
   }
 
   protected build(node: HTMLElement) {

diff --git a/src/ui/dialogs/StringFilterDialog.ts b/src/ui/dialogs/StringFilterDialog.ts
@@ -12,7 +12,7 @@ export default class StringFilterDialog extends ADialog {
 
   constructor(private readonly column: StringColumn, dialog: IDialogContext) {
     super(dialog, {
-      livePreview: dialog.manager.liveFilterPreviews
+      livePreview: dialog.manager.livePreviews.includes('filter')
     });
 
     this.before = this.column.getFilter();