mark all dialog todos

lineupjs · Mar 17, 2020 · 9700562 · 9700562
1 parent 8400125
commit 9700562
Show file tree

Hide file tree

Showing 16 changed files with 22 additions and 19 deletions.
diff --git a/src/ui/dialogs/ADialog.ts b/src/ui/dialogs/ADialog.ts
@@ -167,12 +167,6 @@ abstract class ADialog {
     return (<M[]>Array.from(this.node.querySelectorAll(selector))).map(callback);
   }
 
-  protected readonly changed = () => {
-    if (this.options.livePreview) {
-      this.submit();
-    }
-  }
-
   protected abstract reset(): void;
 
   protected abstract submit(): boolean;

diff --git a/src/ui/dialogs/AddonDialog.ts b/src/ui/dialogs/AddonDialog.ts
@@ -4,7 +4,8 @@ import {IToolbarDialogAddon, IRankingHeaderContext} from '../interfaces';
 
 /** @internal */
 export default class AddonDialog extends ADialog {
-  constructor(private readonly column: Column, private readonly addons: IToolbarDialogAddon[], dialog: IDialogContext, private readonly ctx: IRankingHeaderContext, private readonly onClick?: ()=>void) {
+  constructor(private readonly column: Column, private readonly addons: IToolbarDialogAddon[], dialog: IDialogContext, private readonly ctx: IRankingHeaderContext, private readonly onClick?: () => void) {
+    // TODO dialog
     super(dialog, {
       fullDialog: Boolean(onClick),
       resetPossible: false

diff --git a/src/ui/dialogs/BooleanFilterDialog.ts b/src/ui/dialogs/BooleanFilterDialog.ts
@@ -19,7 +19,7 @@ export default class BooleanFilterDialog extends ADialog {
      <label class="${cssClass('checkbox')}"><input type="radio" name="boolean_check" value="true" ${this.before === true ? 'checked="checked"' : ''}><span>True</span></label>
      <label class="${cssClass('checkbox')}"><input type="radio" name="boolean_check" value="false" ${this.before === false ? 'checked="checked"' : ''}><span>False</span></label>
     `);
-    this.forEach('input[type=radio]', (elem: HTMLInputElement) => elem.onclick = this.changed);
+    this.enableLivePreviews('input[type=radio]');
   }
 
   private updateFilter(filter: boolean | null) {

diff --git a/src/ui/dialogs/ChangeRendererDialog.ts b/src/ui/dialogs/ChangeRendererDialog.ts
@@ -45,7 +45,7 @@ export default class ChangeRendererDialog extends ADialog {
   }
 
   protected reset() {
-    // TODO get the defaults from the description
+    // TODO dialog get the defaults from the description
   }
 
   protected submit() {

diff --git a/src/ui/dialogs/ChooseRankingDialog.ts b/src/ui/dialogs/ChooseRankingDialog.ts
@@ -1,8 +1,9 @@
-import ADialog, {IDialogContext} from './ADialog';
+import {IDialogContext} from './ADialog';
 import {cssClass} from '../../styles';
+import APopup from './APopup';
 
 /** @internal */
-export default class ChooseRankingDialog extends ADialog {
+export default class ChooseRankingDialog extends APopup {
 
   constructor(private readonly items: HTMLElement[], dialog: IDialogContext) {
     super(dialog);

diff --git a/src/ui/dialogs/ColorMappingDialog.ts b/src/ui/dialogs/ColorMappingDialog.ts
@@ -96,6 +96,7 @@ export default class ColorMappingDialog extends ADialog {
 
     node.insertAdjacentHTML('beforeend', h);
 
+    // TODO dialog
     this.interactive(node, id);
   }
 

diff --git a/src/ui/dialogs/GroupDialog.ts b/src/ui/dialogs/GroupDialog.ts
@@ -51,6 +51,7 @@ function sortOrder(node: HTMLElement, column: Column, idPrefix: string) {
   updateDisabled(!enabled);
 
   const trigger = () => {
+    // TODO dialog
     ranking.groupBy(column, !enabled ? -1 : order);
     updateDisabled(!enabled);
   };

diff --git a/src/ui/dialogs/MappingDialog.ts b/src/ui/dialogs/MappingDialog.ts
@@ -29,10 +29,9 @@ export default class MappingDialog extends ADialog {
   };
 
   constructor(private readonly column: IMapAbleColumn, dialog: IDialogContext, ctx: IRankingHeaderContext) {
-    super(dialog, {
-      fullDialog: true
-    });
+    super(dialog);
 
+    // TODO dialog
     this.idPrefix = `me${ctx.idPrefix}`;
     this.scale = this.column.getMapping().clone();
     const domain = this.scale.domain;

diff --git a/src/ui/dialogs/NumberFilterDialog.ts b/src/ui/dialogs/NumberFilterDialog.ts
@@ -17,7 +17,7 @@ export default class NumberFilterDialog extends ADialog {
   build(node: HTMLElement) {
     node.classList.add(cssClass('dialog-mapper'));
 
-    // TODO
+    // TODO dialog summary delayed??
 
     // patch in lu-summary and renderer
     const summary = this.ctx.asElement(this.summary.template);

diff --git a/src/ui/dialogs/ReduceDialog.ts b/src/ui/dialogs/ReduceDialog.ts
@@ -2,6 +2,7 @@ import {EAdvancedSortMethod, ReduceColumn} from '../../model';
 import ADialog, {IDialogContext} from './ADialog';
 import {sortMethods} from './utils';
 
+// TODO dialog
 /** @internal */
 export default class ReduceDialog extends ADialog {
   constructor(private readonly column: ReduceColumn, dialog: IDialogContext) {

diff --git a/src/ui/dialogs/RenameDialog.ts b/src/ui/dialogs/RenameDialog.ts
@@ -21,7 +21,7 @@ export default class RenameDialog extends ADialog {
   }
 
   protected reset() {
-    // TODO not just before but defaults
+    // TODO dialog not just before but defaults
     this.findInput('input[type="text"]').value = this.before.label;
     this.findInput('input[name="summary"]').value = this.before.summary;
     this.node.querySelector('textarea')!.value = this.before.description;

diff --git a/src/ui/dialogs/SortDialog.ts b/src/ui/dialogs/SortDialog.ts
@@ -5,6 +5,7 @@ import {getToolbarDialogAddons} from '../toolbar';
 import {IRankingHeaderContext, IToolbarDialogAddon} from '../interfaces';
 import {cssClass} from '../../styles';
 
+// TODO dialog
 /** @internal */
 export default class SortDialog extends ADialog {
   private readonly addons: IToolbarDialogAddon[];

diff --git a/src/ui/dialogs/groupDate.ts b/src/ui/dialogs/groupDate.ts
@@ -25,6 +25,7 @@ export default function appendDate(col: DateColumn, node: HTMLElement) {
   node.insertAdjacentHTML('beforeend', html);
 
   const update = () => {
+    // TODO dialog
     col.setDateGrouper({granularity, circular});
   };
 

diff --git a/src/ui/dialogs/groupNumber.ts b/src/ui/dialogs/groupNumber.ts
@@ -6,7 +6,7 @@ import {cssClass} from '../../styles';
 
 
 /** @internal */
-export default function append(col: NumberColumn, node: HTMLElement, dialog: IDialogContext) {
+export default function groupNumber(col: NumberColumn, node: HTMLElement, dialog: IDialogContext) {
   const domain = col.getMapping().domain;
   const current = col.getGroupThresholds();
   let isThreshold = current.length <= 1;
@@ -34,6 +34,7 @@ export default function append(col: NumberColumn, node: HTMLElement, dialog: IDi
     bins.disabled = isThreshold;
 
     if (isThreshold) {
+      // TODO dialog
       col.setGroupThresholds([threshold.valueAsNumber]);
       return;
     }

diff --git a/src/ui/dialogs/groupString.ts b/src/ui/dialogs/groupString.ts
@@ -1,9 +1,9 @@
 import {IDialogContext} from './ADialog';
 import {StringColumn, EStringGroupCriteriaType} from '../../model';
-import {cssClass} from '../../styles/index';
+import {cssClass} from '../../styles';
 
 /** @internal */
-export default function append(col: StringColumn, node: HTMLElement, dialog: IDialogContext) {
+export default function groupString(col: StringColumn, node: HTMLElement, dialog: IDialogContext) {
   const current = col.getGroupCriteria();
   const {type, values} = current;
 
@@ -57,6 +57,7 @@ export default function append(col: StringColumn, node: HTMLElement, dialog: IDi
     if (newType === EStringGroupCriteriaType.regex) {
       items = items.map((d) => new RegExp(d.toString(), 'gm'));
     }
+    // TODO dialog
     col.setGroupCriteria({
       type: newType,
       values: items

diff --git a/src/ui/dialogs/utils.ts b/src/ui/dialogs/utils.ts
@@ -22,6 +22,7 @@ export function updateFilterState(attachment: HTMLElement, column: Column, filte
   Array.from(root.querySelectorAll(`[data-col-id="${column.id}"] i[title^=Filter]`)).forEach(toggle);
 }
 
+// TODO dialog
 /** @internal */
 export function sortMethods(node: HTMLElement, column: {setSortMethod(v: string): void, getSortMethod(): string}, methods: string[]) {
   const bak = column.getSortMethod();