fix linting

lineupjs · Dec 17, 2018 · a6c35c9 · a6c35c9
1 parent 723116f
commit a6c35c9
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 20 deletions.
diff --git a/src/provider/LocalDataProvider.ts b/src/provider/LocalDataProvider.ts
@@ -173,14 +173,6 @@ export default class LocalDataProvider extends ACommonDataProvider {
     const addKey = `${Ranking.EVENT_ADD_COLUMN}.cache`;
     const removeKey = `${Ranking.EVENT_REMOVE_COLUMN}.cache`;
 
-    const addCol = (col: Column) => {
-      this.tasks.preComputeCol(col);
-      if (col instanceof CompositeColumn) {
-        col.on(addKey, addCol);
-        col.on(removeKey, removeCol);
-      }
-    };
-
     const removeCol = (col: Column) => {
       this.tasks.dirtyColumn(col, 'data');
       if (col instanceof CompositeColumn) {
@@ -189,6 +181,14 @@ export default class LocalDataProvider extends ACommonDataProvider {
       }
     };
 
+    const addCol = (col: Column) => {
+      this.tasks.preComputeCol(col);
+      if (col instanceof CompositeColumn) {
+        col.on(addKey, addCol);
+        col.on(removeKey, removeCol);
+      }
+    };
+
 
     ranking.on(addKey, addCol);
     ranking.on(removeKey, removeCol);

diff --git a/src/styles/_common.scss b/src/styles/_common.scss
@@ -19,7 +19,7 @@
     pointer-events: none !important;
   }
 
-  >* {
+  > * {
     pointer-events: none !important;
   }
 }
@@ -29,11 +29,11 @@
 }
 
 .#{$lu_css_prefix}-checkbox {
-  >input {
+  > input {
     display: inline;
   }
 
-  >label {
+  > label {
     display: inline-flex;
   }
 }
@@ -49,27 +49,27 @@
   line-height: 0;
   display: flex;
 
-  input:checked+label {
+  input:checked + label {
     outline: 2px solid black;
   }
 
-  >input {
+  > input {
     display: none;
   }
 
-  >label {
+  > label {
     flex: 1 1 0;
   }
 }
 
 .#{$lu_css_prefix}-color-gradient {
   display: flex;
 
-  input:checked+label {
+  input:checked + label {
     outline: 2px solid black;
   }
 
-  >label {
+  > label {
     margin: 0.1em;
     flex: 1 1 auto;
   }
@@ -98,7 +98,7 @@
   background-size: $lu_missing_dash_width $lu_missing_dash_height;
   background-repeat: no-repeat;
 
-  >* {
+  > * {
     display: none;
   }
 }

diff --git a/src/styles/renderer/_aggregate.scss b/src/styles/renderer/_aggregate.scss
@@ -10,15 +10,15 @@
 }
 
 .#{$engine_css_prefix}-td.#{$lu_css_prefix}-renderer-aggregate[data-meta]::before {
+
   // square bracket around
   content: '';
   pointer-events: none;
   position: absolute;
   left: 2px;
   top: -2px;
-  bottom: 0px;
+  bottom: 0;
   width: $lu_aggregate_square_bracket_width;
-
   border-left: $lu_aggregate_square_bracket_stroke_width solid $lu_aggregate_square_bracket_stroke_color;
 }
 

diff --git a/tslint.json b/tslint.json
@@ -62,7 +62,7 @@
     "no-switch-case-fall-through": true,
     "no-trailing-whitespace": true,
     "no-unused-expression": true,
-    "no-use-before-declare": true,
+    "no-use-before-declare": false,
     "no-unsafe-finally": true,
     "no-var-requires": true,
     "no-var-keyword": true,