Merge pull request #659 from lineupjs/release/v4.10.0

Release v4.10.0

.github/workflows/ci.yml

@@ -1,19 +1,21 @@
 name: ci
 
-on: [push]
+on:
+  - push
+  - pull_request
 
 jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
-          node-version: 16
+          node-version: 20
       - run: npm i -g yarn
       - run: yarn config set checksumBehavior ignore
       - name: Cache Node.js modules
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         with:
           path: |
             ./.yarn/cache
@@ -30,7 +32,7 @@ jobs:
       - run: yarn test:coverage
       - run: yarn cy:compile
       - run: yarn cy:junit
-      - uses: actions/upload-artifact@v2
+      - uses: actions/upload-artifact@v4
         if: failure()
         with:
           name: cypress-artifacts

.github/workflows/create_release.yml

@@ -17,7 +17,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Check out code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           ref: main
           ssh-key: ${{ secrets.SSH_PRIVATE_KEY }}
@@ -31,7 +31,7 @@ jobs:
           echo -n "::set-output name=next_tag::"
           npm version --no-git-tag-version ${{ github.event.inputs.versionName }} --preid ${{ github.event.inputs.preid }}
       - name: Create pull request into main
-        uses: peter-evans/create-pull-request@v5
+        uses: peter-evans/create-pull-request@v6
         with:
           branch: release/${{ steps.version.outputs.next_tag }}
           commit-message: 'chore: release ${{ steps.version.outputs.next_tag }}'

.github/workflows/release_main.yml

@@ -18,10 +18,10 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Check out code
-        uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+        uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
-          node-version: 16
+          node-version: 20
       - name: Extract version
         id: extract_version
         run: |
@@ -32,7 +32,7 @@ jobs:
           echo "releasing ${{ steps.extract_version.outputs.version }} with tag ${{ steps.extract_version.outputs.npm_tag }}"
       - name: Create Release
         id: create_release
-        uses: release-drafter/release-drafter@v5
+        uses: release-drafter/release-drafter@v6
         env:
           GITHUB_TOKEN: ${{ secrets.PRIVATE_GITHUB_TOKEN }}
         with:
@@ -51,14 +51,14 @@ jobs:
     needs: create_release
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
-          node-version: 16
+          node-version: 20
       - run: npm i -g yarn
       - run: yarn config set checksumBehavior ignore
       - name: Cache Node.js modules
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         with:
           path: |
             ./.yarn/cache
@@ -75,7 +75,7 @@ jobs:
       - run: yarn test:coverage
       - run: yarn cy:compile
       - run: yarn cy:junit
-      - uses: actions/upload-artifact@v2
+      - uses: actions/upload-artifact@v4
         if: failure()
         with:
           name: cypress-artifacts
@@ -118,7 +118,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Check out code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           ref: develop
           ssh-key: ${{ secrets.SSH_PRIVATE_KEY }}

.stylelintrc

@@ -6,11 +6,8 @@
   "rules": {
     "keyframes-name-pattern": null,
     "no-descending-specificity": null,
-    "value-list-comma-newline-after": null,
-    "declaration-colon-newline-after": null,
     "at-rule-no-unknown": null,
     "at-rule-empty-line-before": null,
-    "block-closing-brace-newline-after": null,
     "selector-id-pattern": null,
     "scss/at-rule-no-unknown": true,
     "scss/no-global-function-names": null,
@@ -21,7 +18,6 @@
     "scss/at-function-pattern": null,
     "scss/at-if-closing-brace-newline-after": "always-last-in-chain",
     "scss/at-if-closing-brace-space-after": "always-intermediate",
-    "scss/at-import-no-partial-leading-underscore": true,
     "scss/at-import-partial-extension-blacklist": null,
     "scss/at-import-partial-extension-whitelist": null,
     "scss/at-mixin-argumentless-call-parentheses": "always",

.yarnrc.yml

@@ -3,4 +3,4 @@ packageExtensions:
     dependencies:
       typescript: ~4.1.5
 
-yarnPath: .yarn/releases/yarn-3.6.1.cjs
+yarnPath: .yarn/releases/yarn-4.0.2.cjs

cypress/index.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

cypress/integration/issue-322_group-boxplot-missing-values.spec.ts

@@ -33,6 +33,9 @@ describe('issue 322', () => {
   it('Check for .lu-missing in boxplot renderer', () => {
     aggregateAll();
 
-    cy.get('.le-tr[data-index="0"] > .lu-renderer-boxplot[data-group="g"]').should('have.class', 'lu-missing');
+    cy.wait(200)
+      .get('.le-tr[data-index="0"] > .lu-renderer-boxplot[data-group="g"]')
+      .wait(200)
+      .should('have.class', 'lu-missing');
   });
 });

cypress/tsconfig.json

@@ -18,9 +18,9 @@
       "d3-time",
       "d3-time-format",
       "detect-browser",
-      "lodash.get"
-    ]
+      "lodash.get",
+    ],
   },
   "include": ["**/*.ts"],
-  "exclude": ["**/*.d.ts"]
+  "exclude": ["**/*.d.ts"],
 }

demo/_after.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

demo/_before.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

demo/aggregate.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

demo/aids.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

demo/big.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

demo/big_d.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

demo/bool.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

demo/boxplot.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

demo/builder.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

demo/builder2.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

demo/builder3.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

demo/builder4.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

demo/categories.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

demo/column_resize.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

demo/complex_accessor.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

demo/custom_column.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

demo/cypress/index.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

demo/dates.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

demo/deriveLink.html

@@ -0,0 +1,30 @@
+<!doctype html>
+<html>
+  <head lang="en">
+    <meta charset="UTF-8" />
+    <title>LineUp Builder Test</title>
+
+    <link href="./LineUpJS.css" rel="stylesheet" />
+    <link href="./demo.css" rel="stylesheet" />
+  </head>
+  <body>
+    <script src="./LineUpJS.js"></script>
+
+    <script>
+      window.onload = function () {
+        const arr = [];
+        const cats = ['c1', 'c2', 'c3'];
+        for (let i = 0; i < 100; ++i) {
+          arr.push({
+            s: 'Row ' + i,
+            a: Math.random() * 10,
+            cat: cats[Math.floor(Math.random() * 3)],
+            link: `https://duck.com/?q=${i}`,
+            d: new Date(Date.now() - Math.floor(Math.random() * 1000000000000)),
+          });
+        }
+        const lineup = LineUpJS.asTaggle(document.body, arr);
+      };
+    </script>
+  </body>
+</html>

demo/dialog.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

demo/dump.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

demo/fontawesome.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

demo/frozen.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

demo/group.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

demo/group3.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

demo/grouping.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

demo/grouping_no_propagate.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

demo/hierarchy.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

demo/htmlLabel.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

demo/image.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

demo/injection.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

demo/invert_mapping.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

demo/lazy_loaded_test.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

demo/link.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />