add othersGroup to avoid defaultGroup

which triggers special behavior
lineupjs · Feb 17, 2019 · f4b1f47 · f4b1f47
1 parent edf026b
commit f4b1f47
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/model/StringColumn.ts b/src/model/StringColumn.ts
@@ -1,6 +1,6 @@
 import {Category, toolbar, dialogAddons} from './annotations';
 import Column, {widthChanged, labelChanged, metaDataChanged, dirty, dirtyHeader, dirtyValues, rendererTypeChanged, groupRendererChanged, summaryRendererChanged, visibilityChanged, dirtyCaches} from './Column';
-import {defaultGroup, IDataRow, IGroup, ECompareValueType, IValueColumnDesc} from './interfaces';
+import {defaultGroup, IDataRow, IGroup, ECompareValueType, IValueColumnDesc, othersGroup} from './interfaces';
 import {missingGroup, isMissingValue} from './missing';
 import ValueColumn, {dataLoaded} from './ValueColumn';
 import {equal, IEventListener} from '../internal';
@@ -182,12 +182,12 @@ export default class StringColumn extends ValueColumn<string> {
     }
 
     if (this.currentGroupCriteria.length === 0) {
-      return defaultGroup;
+      return othersGroup;
     }
     const value = this.getLabel(row);
 
     if (!value) {
-      return defaultGroup;
+      return missingGroup;
     }
 
     for (const criteria of this.currentGroupCriteria) {
@@ -199,7 +199,7 @@ export default class StringColumn extends ValueColumn<string> {
         color: defaultGroup.color
       };
     }
-    return defaultGroup;
+    return othersGroup;
   }
 
 

diff --git a/src/model/interfaces.ts b/src/model/interfaces.ts
@@ -157,6 +157,11 @@ export const defaultGroup: IGroup = {
   color: 'gray'
 };
 
+export const othersGroup: IGroup = {
+  name: 'Others',
+  color: 'gray'
+};
+
 
 export interface IGroupParent extends IGroup {
   subGroups: (Readonly<IGroupParent> | Readonly<IGroup>)[];