Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change input domain for numerical column does not work #165

Closed
thinkh opened this issue Jul 12, 2019 · 0 comments
Closed

Change input domain for numerical column does not work #165

thinkh opened this issue Jul 12, 2019 · 0 comments
Assignees
@sgratzl
Labels
lineup: v4 All issues related to LineUp v4 type: bug Something isn't working
Projects
lineup

Comments

@thinkh
Copy link
Member

thinkh commented Jul 12, 2019

  • Release number or git hash: LineUp.js v4.0.0-alpha.10
  • Web browser version and OS: Chrome 76-beta

Steps to reproduce

  1. Open https://lineup.js.org/app_develop/#soccer
  2. Age -> Data Mapping
  3. Change input domain (e.g., set minimum value to 0)
  4. Apply change

Observed behavior

The change is not applied in LineUp v4.0.0-alpha.10, but works in 3.1.7.

LineUp v4.0.0-alpha.10 --> does not work

lineup4-data-mapping

LineUp v3.1.7 --> works

lineup3-data-mapping

Expected behavior

The data mapping should also work in LineUp v4.
@thinkh thinkh added type: bug Something isn't working lineup: v4 All issues related to LineUp v4 labels Jul 12, 2019
@thinkh thinkh added this to New Issues in lineup via automation Jul 12, 2019
@sgratzl sgratzl moved this from New Issues to To do in lineup Jul 26, 2019
sgratzl added a commit that referenced this issue Sep 30, 2019
@sgratzl
fix #165 cannot edit raw domain
a76fb23
@sgratzl sgratzl self-assigned this Sep 30, 2019
@sgratzl sgratzl moved this from To do to Needs review in lineup Sep 30, 2019
@sgratzl sgratzl moved this from Needs review to Done in lineup Sep 30, 2019
@sgratzl sgratzl closed this as completed Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgratzl sgratzl

Labels
lineup: v4 All issues related to LineUp v4 type: bug Something isn't working
Projects
No open projects
lineup
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgratzl @thinkh