Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Sort Group By in StringColumn #225

Closed
puehringer opened this issue Jan 14, 2020 · 1 comment · Fixed by #275
Closed

Missing Sort Group By in StringColumn #225

puehringer opened this issue Jan 14, 2020 · 1 comment · Fixed by #275
Assignees
@sgratzl
Labels
lineup: v4 All issues related to LineUp v4 type: feature New feature or request
Projects
lineup

Comments

@puehringer
Copy link
Contributor

  • Release number or git hash: v4.0.0-alpha.12
  • Web browser version and OS: any

Steps to reproduce

  1. Group a StringColumn

Observed behavior

Sort applies to rows within group, there is no way to sort the groups themselves (like in a CategoricalColumn).

Expected behavior

Sort group by similar to the CategoricalColumn option.
@puehringer puehringer added the type: feature New feature or request label Jan 14, 2020
@thinkh thinkh added the lineup: v4 All issues related to LineUp v4 label Feb 10, 2020
@sgratzl sgratzl added this to Needs review in lineup Mar 20, 2020
@sgratzl sgratzl moved this from Needs review to To do in lineup Mar 20, 2020
@thinkh thinkh mentioned this issue Mar 23, 2020
Closed
@sgratzl
Copy link
Member

sgratzl commented Mar 25, 2020

what is the sorting logic in case the user wants to sort groups by a string even tho it is not used as a grouping criteria?

sgratzl added a commit that referenced this issue Mar 25, 2020
@sgratzl
closes #225 simple string sort group by
99785a5
@sgratzl sgratzl mentioned this issue Mar 25, 2020
Merged
4 tasks
@sgratzl sgratzl linked a pull request Mar 25, 2020 that will close this issue
Add missing Sort Group By for StringColumn #275
Merged
4 tasks
@sgratzl sgratzl closed this as completed Mar 26, 2020
lineup automation moved this from To do to Done Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgratzl sgratzl

Labels
lineup: v4 All issues related to LineUp v4 type: feature New feature or request
Projects
No open projects
lineup
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing Sort Group By for StringColumn lineupjs/lineupjs
3 participants
@sgratzl @thinkh @puehringer